OVA: Remove the break to properly consume stderr #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bella Khizgiyaev <[email protected]>
|
bkhizgiy
changed the title
brake to properly consume stderr.
liranr23
changed the title
liranr23
approved these changes
Mar 26, 2024
ahadas
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When breaking the scanner loop for firmware detection, we cause the virt-v2v pod to run indefinitely. The call to virtV2vCmd.Wait() waits for the virtV2vCmd process to exit. However, once its
stdoutorstderris not being consumed—in our case, the consumer, virtV2vMonitorCmd forstdout, and the scanning loop forstderr—so once we break the loop, the consumption stops, and the main command will wait forever for an action that will not happen.It was intentionally dropped from the code, and I've missed that part addition in the previous code review.